-
Notifications
You must be signed in to change notification settings - Fork 16.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Replay running again #13885
Merged
Merged
Get Replay running again #13885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
2 times, most recently
from
March 26, 2020 22:55
d391b18
to
5049c9a
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
from
May 19, 2020 09:24
5049c9a
to
78d5878
Compare
thanks for the work on this! |
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
from
May 21, 2020 23:40
78d5878
to
91dde45
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
from
June 12, 2020 10:43
91dde45
to
e48971f
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
2 times, most recently
from
July 7, 2020 23:30
b30771d
to
a31db11
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
2 times, most recently
from
August 20, 2020 01:51
87bbbc7
to
47481be
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
3 times, most recently
from
September 6, 2020 06:52
e44798f
to
dd9ca9e
Compare
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
from
September 10, 2020 22:51
dd9ca9e
to
2aa3b6d
Compare
Replay: tear down threads before exitting NKQ is a generated name - don't copy it across to output Stop whinging about presence of NKF6 and friends; we know these generated names are not going to be present in modern logs memcpy rather than strncpy within log_FMT Correct strings vs optionally-terminated structure entries in sanity checks Call AP_Param::load_all() to start the parameter saving thread. AP_Compass' init() method now saves parameters (compass reordering), and because we're disarmed we will block until the parameter is pushed onto the to-save queue; if there's no thread popping off that list we block indefinitely. Remove duplicate definitions of various singleton objects. Replay: write out GPS message to output log Useful for diagnosis, but also because we struggle to find a time base without this and the pymavlink tools take forever to work Replay: set COMPASS_DEV_ID and COMPASS_PRIO1_ID so EKF gets mag data Replay: avoid use of system clock; use stopped-clock only Replay: constraint to emitting output for single core only
We haven't initialised the GCS at all, so it's not a great idea to update_receive() and the like.
Also don't compile in the stop_clock symbol to make it clear changes in this method won't affect vehicles
peterbarker
force-pushed
the
pr/replay-at-least-runs
branch
from
September 11, 2020 00:50
2aa3b6d
to
270aed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small-effort attempt to get Replay running in the form that it has traditionally run in, feeding sensor data in from our existing BARO, GPS messages etc.
It does run, and does reproduce both successful replication of a flight and at least one (justifiable!) FPE.
Future work will look at changing Replay to log input to the EKFs as separate messages which should give us a less-prone-to-break tool.